Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasmtime: build release artifacts with all-arch. #5657

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Jan 30, 2023

This allows the wasmtime binary provided in our release artifacts to cross-compile: wasmtime compile can build a .cwasm for any platform that Wasmtime supports, not just the host platform. This may be useful in some deployment scenarios.

We don't turn on all-arch by default because it increases build time and binary size of Wasmtime itself, and other embedders of the wasmtime crate won't necessarily want this; hence, we set it only as part of the CI build configuration.

Fixes #5655.

This allows the `wasmtime` binary provided in our release artifacts to
cross-compile: `wasmtime compile` can build a `.cwasm` for any platform
that Wasmtime supports, not just the host platform. This may be useful
in some deployment scenarios.

We don't turn on `all-arch` by default because it increases build time
and binary size of Wasmtime itself, and other embedders of the
`wasmtime` crate won't necessarily want this; hence, we set it only as
part of the CI build configuration.

Fixes bytecodealliance#5655.
@cfallin cfallin enabled auto-merge (squash) January 30, 2023 21:49
@cfallin cfallin merged commit f488d93 into bytecodealliance:main Jan 30, 2023
@martindevans
Copy link
Contributor

Do you know roughly when this will make it into a release?

@cfallin cfallin deleted the release-assets-all-arch branch January 30, 2023 23:35
@alexcrichton
Copy link
Member

Our release process is documented here and this'll get released with 6.0.0 on February 20

@alexcrichton
Copy link
Member

@cfallin it looks like this failed on main, which can track since the "Build" CI isn't run on PRs any more. Would you be up for investigating that?

@alexcrichton
Copy link
Member

Ah nevermind looks like it was failing before this too, I'll try to dig in later

@cfallin
Copy link
Member Author

cfallin commented Jan 30, 2023

I had verified it builds locally, so at least the --features all-arch is harmless, I think. As a random guess/hunch, "permission denied" copying the build result may be because the Dockerized CentOS build container writes files as root? Perhaps something updated or changed recently related to that?

@alexcrichton
Copy link
Member

Oh @martindevans I forgot about this but you can also test out the artifacts from the dev tag while a release hasn't been made yet.

@martindevans
Copy link
Contributor

The wasmtime.exe from the linked tag works for me 👍

I didn't test the equivalent binaries on any other platforms though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable all-arch by default.
3 participants